Okay so this is a 97 Sunfire 2.2 Im trying to get started. Its been driven maybe once a month for the last 6 months but last summer I had the timing chain and battery replaced. The summer before that we did the starter and alternator.
Weve been having a rough running issue (the reason for not driving the car) so the other day I went out just to take a look-see. Turn the key and nothing, all inside lights, headlights, radio and everythings working. Took the battery out and put in on the charger in the house, put it back in and nothing. Once every few tries solenoid clicks but never cranks, if i wack it with a hammer it will click but still no crank.
Whats ur opinions on this one? is my battery shot or my starter? maybe some wiring?

Sounds like the starter armature went to ground. Remove it and see if a pair of jump cables will spin it or take it to a rebuild shop.

The last time i tried to start a few weeks ago it cranked slow a few times then i got one lil poof of smoke out of the starter so that could be....would it be the actual starter or the solenoid?

I tried jumping the terminals and got nothing but sparks.
my wiring is
big red wire to top post
there is two red wires off the relay one goes to the top pos post
the other turns purple and its on the small bottom terminal by itself
the black wire out of the relay goes back to the neg batt post
and theres a red wire coming out of the engine harness that goes to the top pos post.

does this all sound correct?

I dunno about the wiring, but if you got smoke from the starter.... Sounds like a dead starter to me. Replace it.

Yeah once you let the smoke out she's done. with all wired and installed touch screwdriver from small purple terminal to big lug in center of solenoid. Must use force and touch it firmly soft touch will cause sparks.